Skip to content

(maint) Prime Feature and Instance installation with .Net 3.5 source #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2017
Merged

(maint) Prime Feature and Instance installation with .Net 3.5 source #197

merged 1 commit into from
Feb 1, 2017

Conversation

@wilson208
Copy link
Contributor

@wilson208 wilson208 commented Jan 24, 2017 •
edited by glennsarti
Loading

Previously, there was known bug with installing .Net Framework 3.5 on Server
2012R2 due to the installation media not making the required features available,
instead they were removed. This commit copies and mounts a Windows Server
2012 R2 installation ISO and uses the windows_feature_source property in the
module to use the I:\source\sxs folder for feature installation components.

glennsarti
glennsarti suggested changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL Server module already installs dot net framework.

See

puppetlabs-sqlserver/lib/puppet/provider/sqlserver.rb

Lines 51 to 71 in bb38c4c

install_dot_net = <<-DOTNET
$Result = Dism /online /Get-featureinfo /featurename:NetFx3
If($Result -contains "State : Enabled")
{
Write-Host ".Net Framework 3.5 is already installed."
}
Else
{
Write-Host "Installing .Net Framework 3.5, do not close this prompt..."
DISM /Online /Enable-Feature /FeatureName:NetFx3 /All /NoRestart /Quiet /LimitAccess #{ "/Source:\"#{source_location}\"" unless source_location.nil? } | Out-Null
$Result = Dism /online /Get-featureinfo /featurename:NetFx3
If($Result -contains "State : Enabled")
{
Write-Host "Install .Net Framework 3.5 successfully."
}
Else
{
Write-Host "Failed to install Install .Net Framework 3.5#{ ", please make sure the windows_feature_source is correct" unless source_location.nil?}."
}
}
DOTNET

@glennsarti
Copy link
Contributor

glennsarti commented Jan 31, 2017 •
edited
Loading

@wilson208 Ran this through adhoc and it completed with success. Just need to cleanup the commit messages and this is good for merge.

@glennsarti
(maint) Prime Feature and Instance installation with .Net 3.5 source
72a3053 
Previously, there was known bug with installing .Net Framework 3.5 on Server
2012R2 due to the installation media not making the required features available,
instead they were removed.  This commit copies and mounts a Windows Server
2012 R2 installation ISO and uses the `windows_feature_source`  property in the
module to use the `I:\source\sxs` folder for feature installation components.
@glennsarti glennsarti changed the title [WIP] Install .NET 3.5 in spec_helper_acceptance.rb (maint) Prime Feature and Instance installation with .Net 3.5 source Feb 1, 2017
@eputnam eputnam merged commit ba8cfba into puppetlabs:master Feb 1, 2017
@wilson208 wilson208 deleted the dotnet35-install branch February 3, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@glennsarti glennsarti glennsarti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wilson208 @glennsarti @eputnam